No signalling layer update has taken place for a long time. Maybe is another restart necessary?
I would like to see some Swedish railway signals. They do exist in OSM already. Wonder how I could contribute?
Hello,
basically you need to contribute on the source code by forking on github.com/OpenRailwayMap/ and provide/enhance (it seems to be quite rudimentary atm) the tagging rules on https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging_in_Sweden.
Maybe it's best to start with signals that are already mapped.
On github it's multiple things to do:
- create symbols for both JOSM and the map
- create JOSM preset (https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/josm-presets)
- create ruleset for rendering (https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/styles and/or https://github.com/OpenRailwayMap/OpenRailwayMap-CartoCSS/)
- potentially add information on taginfo and the validator if you have rules (but it's not nicely covered atm)
If it's new ruleset-files, you need to put the information of them to be used at the proper file (don't know which atm).
Create a pull request if you want it merged. (there can/will be some discussion though), or an issue for discussion beforehand.
Yet, I don't know how to proceed for different editors as they seem to not be preferred for ORM.
Best regards
PS: Is CartoCSS already in use?
PPS: How to proceed with ETCS markers as they should(?) be equal in europe but have different names due to different operating countries? The symbols could be reused, but what about the railway:signal:train_protection-Tagging? But it's definitely not wrong to use distinct tagging… (and yet it sounds very generic name "train_protection" as it's basically quite similar to main signals but yet completely different. How to change that at some time in the future (I'm thinking about sth like display-led marker boards or something similar?)
Am 21.03.23 um 18:29 schrieb tomasmarklund75@gmail.com:
I would like to see some Swedish railway signals. They do exist in OSM already. Wonder how I could contribute? Openrailwaymap mailing list -- openrailwaymap@openrailwaymap.org To unsubscribe send an email to openrailwaymap-leave@openrailwaymap.org Archived version of this message: https://lists.openrailwaymap.org/mailman3/hyperkitty/list/openrailwaymap@ope... Archive of this list: https://lists.openrailwaymap.org/mailman3/hyperkitty/list/openrailwaymap@ope...
PS: Is CartoCSS already in use?
CartoCSS is used for the web rendering, while MapCSS is used for JOSM. The split is unfortunate, but maintaining our own rendering stack that understands MapCSS will not work because of too few developers. We did this for some years, but at the end the development of the stack just halted because everyone has more important things to do.
PPS: How to proceed with ETCS markers as they should(?) be equal in europe but have different names due to different operating countries?
We use the same markers for multiple countries already:
https://github.com/OpenRailwayMap/OpenRailwayMap-CartoCSS/blob/master/ signals.mss#L660
Björn Mahrt wrote:
basically you need to contribute on the source code by forking on github
Oh, I don't think I'm qualified to do forks on github :-/ Could someone help me getting started perhaps?
..and provide/enhance (it seems to be quite rudimentary atm) the tagging rules on
https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging_in_Sweden.
I made that page, and even if it seems rudimentary, it covers all the main signals :-)
Maybe it's best to start with signals that are already mapped.
On github it's multiple things to do:
- create symbols for both JOSM and the map
That I can do. Where and how?
- create JOSM preset
(https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/josm-presets)
Don't relly think that JOSM presets are necessary, all the main signals are already in OSM.
- create ruleset for rendering
(https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/styles and/or https://github.com/OpenRailwayMap/OpenRailwayMap-CartoCSS/)
Don't really know how to start, but if someone gives me a hand..
- potentially add information on taginfo and the validator if you have
rules (but it's not nicely covered atm)
If it's new ruleset-files, you need to put the information of them to be used at the proper file (don't know which atm).
Create a pull request if you want it merged. (there can/will be some discussion though), or an issue for discussion beforehand.
Don't know how to do that :-(
Yet, I don't know how to proceed for different editors as they seem to not be preferred for ORM.
Best regards
Hello, I will just answer directly inside the text.
Am 26.03.23 um 12:17 schrieb tomasmarklund75@gmail.com:
Björn Mahrt wrote:
basically you need to contribute on the source code by forking on github
Oh, I don't think I'm qualified to do forks on github :-/ Could someone help me getting started perhaps?
https://docs.github.com/en/get-started/quickstart/fork-a-repo
..and provide/enhance (it seems to be quite rudimentary atm) the tagging rules on
https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging_in_Sweden.
I made that page, and even if it seems rudimentary, it covers all the main signals :-)
I'm quite sure that there are more signal types in sweden. You may look into the attachments to the wikipedia page on swedish signals. There are many(!) more :)
Maybe it's best to start with signals that are already mapped.
On github it's multiple things to do:
- create symbols for both JOSM and the map
That I can do. Where and how?
Just look around in the github/OpenRailwayMap/OpenRailwayMap data. There will be icons where you can see how big and etc. they are. Working with svg files went best for me with the program inkscape. After that in the best case create a pull request in github, but it seems (https://wiki.openstreetmap.org/wiki/OpenRailwayMap) that emails are okayish as well. However long it may take then.
I would suggest to start with small changes first and figure out how the toolchain works by itself.
- create JOSM preset
(https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/josm-presets)
Don't relly think that JOSM presets are necessary, all the main signals are already in OSM.
There are so many signals and signal tagging is always a complex case and there will be changes. So I feel that it will be easier in the future. But nice work for all the main signals (we are definitely not yet there for Germany). But if there is both nice documentation in the wiki and the symbols, it will be "just" tedious work.
- create ruleset for rendering
(https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/styles and/or https://github.com/OpenRailwayMap/OpenRailwayMap-CartoCSS/)
Don't really know how to start, but if someone gives me a hand..
I'd suggest that you'd look into the files (I think styles/signals.mapcss, styles/signals.json and signals.mss should be the ones.). You as well need the signals.mml, but thats the sql part and it took a while for me to understand what it does. But if you only have added some things in some of them, one can better start to help. (the /* ... */ parts are comments and tell about what the next part is about).
- potentially add information on taginfo and the validator if you have
rules (but it's not nicely covered atm)
If it's new ruleset-files, you need to put the information of them to be used at the proper file (don't know which atm).
I think for the signals.* files it shouldn't be relevant I think. But that will be one of the latest parts to do.
Create a pull request if you want it merged. (there can/will be some discussion though), or an issue for discussion beforehand.
ORM works somehow like described in https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project under the keyword "Forked Public Project" and pull requests you can easily do on the github webpage. You will find information about that. ANd if something just doesn't work, better ask then (it's easier then describing everything from scratch as I gave you a comprehensive thing of what can be done.)
Best
Björn
Am Dienstag, 21. März 2023, 16:49:30 CET schrieb Axel Zöllich:
No signalling layer update has taken place for a long time. Maybe is another restart necessary?
The queue is quite full, ~400k tiles are waiting for rerendering at the moment. It is slowly decreasing, it was at >600k a week ago or so.
Eike
openrailwaymap@openrailwaymap.org