Hello, I will just answer directly inside the text.
Am 26.03.23 um 12:17 schrieb tomasmarklund75(a)gmail.com:
Björn Mahrt wrote:
> basically you need to contribute on the source code by forking on github
Oh, I don't think I'm qualified to do forks on github :-/ Could someone help me
getting started perhaps?
https://docs.github.com/en/get-started/quickstart/fork-a-repo
> ..and provide/enhance (it seems to be quite rudimentary atm) the
tagging rules on
https://wiki.openstreetmap.org/wiki/OpenRailwayMap/Tagging_in_Sweden.
I made that page, and even if it seems rudimentary, it covers all the main signals :-)
I'm quite sure that there are more signal types in sweden. You may look
into the attachments to the wikipedia page on swedish signals. There are
many(!) more :)
> Maybe it's best to start with signals that are already
mapped.
>
> On github it's multiple things to do:
>
> - create symbols for both JOSM and the map
That I can do. Where and how?
Just look around in the github/OpenRailwayMap/OpenRailwayMap data. There
will be icons where you can see how big and etc. they are. Working with
svg files went best for me with the program inkscape. After that in the
best case create a pull request in github, but it seems
(
https://wiki.openstreetmap.org/wiki/OpenRailwayMap) that emails are
okayish as well. However long it may take then.
I would suggest to start with small changes first and figure out how the
toolchain works by itself.
> - create JOSM preset
> (
https://github.com/OpenRailwayMap/OpenRailwayMap/tree/master/josm-presets)
Don't relly think that JOSM presets are necessary, all the main signals are already
in OSM.
There are so many signals and signal tagging is always a complex case
and there will be changes. So I feel that it will be easier in the
future. But nice work for all the main signals (we are definitely not
yet there for Germany). But if there is both nice documentation in the
wiki and the symbols, it will be "just" tedious work.
I'd suggest that you'd look into the files (I think
styles/signals.mapcss, styles/signals.json and signals.mss should be the
ones.). You as well need the signals.mml, but thats the sql part and it
took a while for me to understand what it does. But if you only have
added some things in some of them, one can better start to help. (the /*
... */ parts are comments and tell about what the next part is about).
> - potentially add information on taginfo and the validator if you
have
> rules (but it's not nicely covered atm)
>
> If it's new ruleset-files, you need to put the information of them to be
> used at the proper file (don't know which atm).
I think for the signals.*
files it shouldn't be relevant I think. But
that will be one of the latest parts to do.
> Create a pull request if you want it merged. (there can/will be
some
> discussion though), or an issue for discussion beforehand.
ORM works somehow like described in
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project
under the keyword "Forked Public Project" and pull requests you can
easily do on the github webpage. You will find information about that.
ANd if something just doesn't work, better ask then (it's easier then
describing everything from scratch as I gave you a comprehensive thing
of what can be done.)
Best
Björn